Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Flex for signup form, floated error icon, flex and vw on desktop body

Jhabari Guidry• 190

@J-Guidry

Desktop design screenshot for the Intro component with sign-up form coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Would it have been ok to include the paragraph under the button in the form tag itself instead of outside necessitating the div?

Community feedback

Alex• 1,090

@AlexBueckig

Posted

Hi @J-Guidry,

in my solution I actually included the parapgraph in the form tag just to get rid of another additional wrapper-div. In my opinion its totally fine to add the paragraph inside to form tag because its a description/legal-notice which is contextually tied to submitting the form/pressing the button.

Maybe someone else can confirm or deny? 😃

1
P
Matt Studdert• 13,611

@mattstuddert

Posted

Hey Jhabari, either way would be fine! You've done a good job on this challenge. One thing I'd recommend is to add the desktop background in for larger screens. At the moment it doesn't change from the mobile background-image.

How did you get on with it? Did you learn anything new while building it?

0

Jhabari Guidry• 190

@J-Guidry

Posted

Wow. The desktop background image completely slipped my mind. How could I forget that? As for learning, I did learn how to make better use of widths and max widths to control centering and space around elements.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord