Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Four card feature section

Erik Tangvikā€¢ 255

@Etang131

Desktop design screenshot for the Four card feature section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Let me know if I can make any improvements.

Community feedback

P
Emmilie Estabilloā€¢ 5,540

@emestabillo

Posted

Hi Erik, looks good! Just a few minor things:

  • I think you don't need line 108 on your CSS @media only screen and (min-width: 3760px). It looks like you started mobile-first, which means these styles will also be loaded first.

  • Same with the lines 109-113:

.heroSection {
    display: flex;
    flex-direction: column;
    justify-content: center;
  }

These divs will naturally stack, so you don't need flexbox to do it for you. If you were looking to center the text, text-align: center will do. Iā€™d also review lines 120-123.

  • For the container, maybe reduce the max-width to the value between the supervisor card and the calculator card, and horizontally center it by using margin: 0 auto. This way, the component will be centered in any screen width, particularly in larger ones beyond 1440px.

  • The cards seem to have no gaps between them around 1300px.

Hope this helps!

2

Erik Tangvikā€¢ 255

@Etang131

Posted

Thanks for the help. Fixing those few things really helped clean up the css a bit.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord