@emestabillo
Posted
Hi Erik, looks good! Just a few minor things:
-
I think you don't need line 108 on your CSS
@media only screen and (min-width: 3760px)
. It looks like you started mobile-first, which means these styles will also be loaded first. -
Same with the lines 109-113:
.heroSection {
display: flex;
flex-direction: column;
justify-content: center;
}
These divs will naturally stack, so you don't need flexbox to do it for you. If you were looking to center the text, text-align: center
will do. Iād also review lines 120-123.
-
For the container, maybe reduce the
max-width
to the value between the supervisor card and the calculator card, and horizontally center it by usingmargin: 0 auto
. This way, the component will be centered in any screen width, particularly in larger ones beyond 1440px. -
The cards seem to have no gaps between them around 1300px.
Hope this helps!
@Etang131
Posted
Thanks for the help. Fixing those few things really helped clean up the css a bit.