isimeri• 250
@isimeri
Posted
Hello! You did a pretty good job on this project. I'd still change a few things, though:
- Remove all the
margin-bottomthat you set up for your cards. As the point of this project is to get you to know Flexbox better, rather set aheightormin-heightfor your.card-sectionand just let thealign-itemsandjustify-contentproperties do their job, instead of using the cards' margins to increase the.card-section's height by force. I'd suggest usingdisplay:flexwith aflex-direction: columnfor.middle-cardsas well, so you don't have to guess margins to position the cards. - Make the
<body>take up the full screen height. I'd actually use somediv.containerfor all the content, so i won't have any regrets if i decide to add some feature to the page some day(but it's no big deal for this specific project). - Remove the
max-width: 1440pxmedia query. The.card-sectionlooks very much wrong for screens wider than that. I know there was some mention in the project's instructions file, about the design being supposed to work for that width, but that shouldn't limit you from making it work for screens wider than 1440px. - The
<footer>is directly below the cards, but that is due to the<body>not taking the entire height of the screen. It really comes down to personal preference in this specific case, but i think it would look better if the<footer>was at the bottom of the screen.
Other than that, you did a great job. Keep it up!
1
Monica• 100
@monicamclaughlan
Posted
@isimeri Thank you very much for your detailed reply, will look into removing the heights and see if I can understand flex box a bit more that way. And I do understand about the footer, and will look into a way to anchor that to the bottom if my content takes up more than the height of the screen. Always learning, thanks again!
0
