@SzymonRojek
Posted
Hi Steve,
Well done :D
I have checked your project, a few tips below:
- instead of div class="cards" I would use the main tag to indicate the main content on your page;
- well done with the alt text (we have got here decorative img so they can be ignored by assistive technologies);
- I'd recommend learning BEM naming convention because at the moment your classes are not readable and descriptive;
- do you need to really use @include in this project? IMO it is unnecessary, you can use just a css variable;
- icon: what's about the height for a img?
- apart from the img, you have set explicit width **=>**important: that's not a good practice especially that you want to use the flexbox or grid. It is essential to understand well the height and width vs min-height/max-height & min-width/max-width. You shouldn’t need to give items height unless they have a background or absolutely-positioned or floated elements within them that would not normally be accounted for in the height of an element. Experienced developers use min-height and min/max-width more than anything else. It allows elements to grow and shrink.
Ps. Don't forget to upvote any comments on here that you find helpful.
Greetings :D
@stevedevsign
Posted
@SzymonRojek wooow very appreciated that feedback, I will do everything you tell me. Thank you so much, your opinion was excellent 🙌
@SzymonRojek
Posted
@stevedevsign
I am glad you are satisfied :D
Happy coding 😀