Alex Kim• 1,325
@alex-kim-dev
Posted
Hey Adarsh, nice solution on this challenge! I like that you added some animation for cards, cool little effects on hover. And that fancy font that you used for the attribution is looking great. I looked into the code and i have some feedback for you:
- the borders on top of the cards are slightly curved which is not in the line with the design
- for 555-768px screen sizes the cards are shifted to the right; also i think for mobile screens (375, 425px) the layout should be 1-column
- the
height
set for every card can cause issues when the content inside changes - the card icons are not pinned to the bottom of the card, if i change text ab...
- there are some css grid properties that can help with aligning the left & right cards vertically
- i think having 7 screen breakpoints is a little too much
Good luck!
1
Adarsh Pratap• 5,515
@adarshcodes
Posted
@Alex-K1m Thank you soo much for taking a look at my solution and also for your valuable suggestions. It was a solution when I started learning front end development🙂.
0