Frontend Mentor | Loopstudios landing page

Community feedback

• 

  

  Chamu•13,860

  @ChamuMutezva

  Posted 2 months ago

  Hi Moundjid Machghour

  Here are some of the issues that you need to look at:

  • first things first, you need to get your HTML right. Among other things, there is duplication of code where you have HTML for Mobile and then HTML for desktop. Probably that can be done in very complex layouts( I cannot think of a case scenario where you would need to do that). You may need to practice more on your CSS.
  • always use semantic elements - elements that have been designed for a specific purpose. In one example like the button that toggle the mobile menu , well , it has to be a button. But in this case you have used images (icon-close and icon-hamburger). Images are not meant for interactive purposes - that is an image can not have click events. You can wrap around the image with a button as the image is just a decorative item.
  • the alt value for an image should carry the message that is carried by the image . If the image is decorative then it should just be alt="" , words such as image, picture, logo etc should not be included in the alt value .
  • the CSS too has issues which are listed below:
  • font sizes should not be in px but preferably use rems.
  • A lot of elements have fixed sizes which will make the site unresponsive

  There is definately a need to start with a smaller challenge and cement the basics. It will be easier to guide you on a smaller challenge fo that it will be helpfull in your future projects.

  Good lucky

  11

  Marked as helpful
• 

  Getahune Alemayhu•100

  @getishe

  Posted 2 months ago

  Great landing page! Make it responsive.

  01