Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Fylo Dark Themed Landing Page

@vishalnirmal

Desktop design screenshot for the Fylo dark theme landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feedbacks are appreciated

Community feedback

Anna Leigh 5,135

@brasspetals

Posted

Hello again, Vishal!

Good job on this challenge! It responds well and looks good when tested on larger screens(1920px). Yet again, just a few suggestions to make it even better:

  • To clear up the errors in your report, simply add labels to your inputs and change the href of your anchor tags to just “#”.
  • If you remove display: flex from your .ext-link, it will stop the border from stretching past the content. I don’t think it’s really necessary to use flex here, as the text and icon line up well without it. However, if you wanted to keep it, adding width: max-content would also prevent the border from stretching.
  • There’s no need to use paragraph tags to wrap the content of your anchor tags.
  • Your email input should be type=“email” rather than “text”.
  • Your .button-get-started should be a button rather than an input.
  • I suggest adding a max-width or another method to prevent your .address from stretching out into one long line on medium layouts. You could also do this with your .feature divs so the content doesn’t get too stretched out.

Hope this is helpful, and as always, happy coding!

2

@vishalnirmal

Posted

Thank you for your suggestions.

0
Roc Tanweer 2,500

@RocTanweer

Posted

Hello bhai, I am wondering why using js? I don't see any reason... Will you explain?

0

@vishalnirmal

Posted

@RocTanweer JS is used for email validation purpose

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord