Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Fylo data storage component challenge hub

@yasser22269

Desktop design screenshot for the Fylo data storage component coding challenge

This is a solution for...

  • HTML
  • CSS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Please feel free to test it, and give me some feedback! (づ。◕‿‿◕。)づ

Community feedback

Dušan Lukić 1,660

@dusanlukic404

Posted

Hey Yasser, nice job congrats! I have a few suggestions for you:

  • Change background-size from initial to contain
  • You should have align-items: flex-end on your .cards
  • Make images on left card same size
  • Check accessibility and HTML issues on your solution so you can see and learn much more, they are very important

Marked as helpful

1

@yasser22269

Posted

@dusanlukic404 thanks , I will correct these errors now.

0
Mike Hayden 1,005

@mickyginger

Posted

Hi Yasser! 👋

This is cool! I have a couple of small suggestions:

The background image is cropped on larger screens. I'm not sure the best approach here, but I think that setting background-size: cover; background-position: 50vh; might make it look reasonable on most viewport sizes.

If you set align-items: flex-end on div.cards the two panels will line up by their bottom edges which matches the design.

The only other thing I would recommend is that you take a look at the progress element. It's not the easiest thing to style, but it makes sense semantically here.

I hope that's useful! 🤓

Marked as helpful

1

@yasser22269

Posted

@mickyginger thanks , I will correct these errors now.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord