@shashilo
Posted
Another great job Roman. The nav link CSS transitions are really cool and the mobile implementation is awesome. I did find some things that can be improved:
- The style guide calls for the
max-width
for desktop to be1440px
. Yours is set at1170px
. This causes the site to look thinner and the columns to not match the design. - All of your headings are using the wrong font. They should be using
var(--ff-heading)
instead ofvar(--ff-body)
- The
Stay productive, wherever you are
seems to be incomplete on desktop. The heading is small and not vertically aligned to the section. - The
Get early access today
CTA container is too thin. It causes the content to feel squished in, but it also doesn't match the design specs. - I like the sticky header, but the transition is wonky. It looks like it's growing then shrinking. When you scroll back up and the sticky header is removed, it jumps a few times before it's removed. I would like to see this get smoothened out.
- Fixing the button :hover transition would be nice too. A nice smooth gradient transition would make this implementation even better.
@rfilenko
Posted
@shashilo hi Shashi, appreciate your feedback, will work on those to polish this up😉