@adedotxn
Latest solutions
Latest comments
- @rfilenko
Hey, good job here, but I see a lot of small issues. To debug some of them use rule - * {outline: 1px solid orange;}. This will help to fix overflow problem. A few points for future projects:
- don't set defined heigth on containers;
- preferable don't use id's for styling;
- img { max-width: 100%;} will make all images responsive;
- it's better to set max-width on wrapping containers instead of just width.
- use flexbox or css gris for layout, don't use position;
- for spacing inside use padding.
Try to fix some issues first, good luck😉
Cheers, Roman
- @Tiasstiass@rfilenko
Hey, you can use grid instead😉, cos currentrly gap for flexbox isn't supported in Safari yet. Or use negative margin/padding for placing items inside flex container.
Cheers, Roman
- @gacbur@rfilenko
Hey, try to fix console error - Mixed Content: The page at 'https://react-clockapp.vercel.app/' was loaded over HTTPS, but requested an insecure resource 'http://worldtimeapi.org/api/ip'. This request has been blocked; the content must be served over HTTPS. Probably this is the issue here
- @mohamed1maghraby-div@rfilenko
Hey, great work. Looks nice, but I have a few notes:
- semantic html can be a little better
- try to avoid deep nesting in css, like body .page .container .card-body h2, it's hard to overwrite and maintain styles.
Cheers, Roman
- @monicamclaughlan@rfilenko
Hey Monica, nice try, but there some issues you can easily fix. First, add your your pattern images as background-image with css, this will fix positioning and overflow issues. And work on previous feedback.
Cheers, Roman
