Latest solutions
Latest comments
- @darryncodes@Tiasstiass
Good job! 👏
Tested it on Safari iOS, looks neat! Few feedbacks:
- Regarding the colored top border:
You could make it a div or the best solution I think, is to use a
::before
pseudo element, - Setting fixed heights is not considered good practice, the content should define the height of an element, be it the padding etc..,
- Any reason behind the
font-size: 50%
, 62.5% makes sense but why 50%? - @import is being depreciated and Sass team is discouraging us to use it, look into @use and @forward,
- You are using scss syntax not sass, consider renaming your folder.
Excellent job overall, keep up the good work 💪
Marked as helpful - Regarding the colored top border:
You could make it a div or the best solution I think, is to use a
- @iliwili@Tiasstiass
Good job! 👏
Nice work overall, some feedbacks:
- You can use
overflow: hidden
for the card’s border-radius to work without setting it on the image as well, - The box shadow is really big on the button, a subtle
0 2px 5px #00000033
should work, - You can apply that shadow on the card as well,
- Use more em and rem, especially rem for font-sizes. If you set a font-size on body and then rem on children, you could change all your font-sizes by just changing the body font-size and the children will scale accordingly.
Keep up the good work 💪
- You can use
- @saurav0896@Tiasstiass
Good job 👏
Looks really good!
- Seems like there is a little gap between the image and the body of the card but its nice that way also.
- The body is too big on mobile, the reason is, you set the width of the body, I guess for background positioning ?
background-size: cover
should do the trick. - Look into em and rem
Keep up the good work 💪
Marked as helpful - @luis123doria@Tiasstiass
Good job!👏
Tested it on Safari iOS, nice work on the card itself, the positioning is off on both portrait and landscape orientation. Also the box-shadow on the card is off and its values looks random, 0 2px 5px #00000033 is usually enough for a card
Keep up the good work 💪
Marked as helpful - @DxnielXndrew@Tiasstiass
Good job! 👏
Tested it on Safari iOS, looks good overall although:
- Centering is kinda off on first and third section,
- The hamburger menu’s items breaks on landscape mode
Now about the code:
- The use of !important is not recommended, if you need it that much, surely something is wrong with your code and using it shouldn’t be your first resort,
- 5 media queries are too much, look for ways to make it more responsive « on its own » like grid, responsive font-sizes with the use of clamp(), not setting fixed sizes, using em and rem etc..
Keep up the good work 💪
Marked as helpful - @futuregit@Tiasstiass
Good job! 👏
Tested it on Safari iOS, looks really good, the only issue I see is the really long hamburger menu.. Is there a reason behind it being 200vh?
Keep up the good work 💪
Marked as helpful