Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

GitHub User Search app with Sass, JS, CSS Grid, Flexbox and Parcel

Dmitryโ€ข 375

@dmitrymitenkoff

Desktop design screenshot for the GitHub user search app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Some feedback on theme toggling would be greatly appreciated. Thanks!

Community feedback

P
The Burrito Doggieโ€ข 1,260

@BurritoDoggie

Posted

Hi!

I love it! It is so cool! I think it is actually very practical and I might use it! It was accurate,and I could find users that actually existed! You did fantastic on the dark mode! I love dark mode. It was really fun to look at people's profiles. Please do more challenges!

Keep Coding!

(โ—โ™กโˆ€โ™ก)

Marked as helpful

2

Dmitryโ€ข 375

@dmitrymitenkoff

Posted

@BurritoDoggie thanks for your feedback! I must say I struggled with the dark mode implementation the most, especially with the CSS part of it. I've added some useful resources to the Readme file - feel free to check those out if you need more info on the topic:)

1
P
Chamuโ€ข 12,970

@ChamuMutezva

Posted

Well done DMITRY

  • some of your images are missing the alt attribute - it is very important to include it. Decorative images can have alt=""
  • on the theme switcher, in it's present state (a div) it is not focusable with a keyboard. Using semantic html should be the first choice.

Happy coding

Marked as helpful

1

Dmitryโ€ข 375

@dmitrymitenkoff

Posted

@ChamuMutezva Hey Chamu, Thanks for your constructive feedback! I ended up adding an empty alt and tab index for the toggle div. Cheers!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord