P
Matt Studdert• 13,611
@mattstuddert
Posted
Hey Jarek, nice work on this challenge! You've done a really good job. I've got a couple of small suggestions that I hope will help you out:
- You're using the
sectionelement for each small area within the component, whereas sections are typically larger groupings of related content. For example, a testimonial section on a page or an introductory section. So I would actually have asectionelement wrapping the whole thing and usedivelements to group the small collections of elements. - Be careful no to nest your selectors unnecessarily in SASS, as you can end up with overly specific selector chains. For example, one of your selectors in currently
.price-component .monthly-subcription .price-container .pricewhen it could just be.price.
I hope this helps. Keep up the great work! 👍
1
Mohamed ELIDRISSI• 150
@MohamedElidrissi
Posted
@mattstuddert Thanks for this, I was abusing the nesting feature in SASS
0
Jarek-Trzybinski• 235
@Jarek-Trzybinski
Posted
@mattstuddert
I've replaced sessions with divs and made sass nesting a bit simpler :)
1
P
Matt Studdert• 13,611
@mattstuddert
Posted
@MohamedElidrissi no problem! Yeah, it's an easy mistake to make in the early days, as it's such a nice way of doing it!
0
