Skip to content
Submitted over 4 years ago

HTML & CSS

buchi•60
@buchi-1996
A solution to the Social proof section challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

please what's the best unit for font sizes (em or pixels)

Code

Please log in to post a comment

Log in

Community feedback

  • buchi•60
    @buchi-1996

    Thanks guys

  • David Payne•1,205
    @dpayne713

    Hey Buchi. I like to use REM as it references the root and scales for people who change their browser default font size.

    Check out this Link about it I found on the CSS tricks website

    https://snook.ca/archives/html_and_css/font-size-with-rem

  • Aleksandr Aksenov•750
    @axevldk

    Hi, @buchi ~ I have studied your work, and great work so far ~ Especially BEM naming is good. Here are some of my opinions.

    1. You can add min-height: 100vh; to body element, so that it can fit whole screen.

    2. In the top left text section paragraph is settled inside h1 tag. I am not sure why you did so, but this isn't good for HTML semantic rule.

    3. You used images tags for background but I think it would be better to use background-image css property or pseudo elements in such cases.

    4. You can set max-width: 1280px; margin: 0 auto; to your container element.

    Hope this will help you even a bit. Happy coding ~ ✨

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord