Latest solutions
Latest comments
- @hns-dev@dpayne713
that's a tricky one. Short answer is 100vh is the full device screen -- NOT the browser available window. In leu of trying to go deeper on this feedback form... check out these resources:
https://stackoverflow.com/questions/37112218/css3-100vh-not-constant-in-mobile-browser
https://chanind.github.io/javascript/2019/09/28/avoid-100vh-on-mobile-web.html
- @bluerhythmz@dpayne713
Hi Bluerhythmz,
Looks nice!
When you have a chance to make it responsive using media queries be sure to re-post. Look forward to seeing it.
Best,
David
- @viet88tp@dpayne713
Hi TP,
You are getting the horizontal scrollbar because your
arrow
div has a width of 500px and is causing that stretching. You should define a width for that to help with this issue.One trick to try is if you have a component that you know is it's own entity and all contents must stay inside is to use
overflow: hidden
on the container for the component. Then anything that overflows will disappear. It's not super helpful for troubleshooting code but has some helpful use cases.Hope this helps.
David
- @nicole-tuznik@dpayne713
Nice Job Nicole,
It looks great and the form validation seems to be fully functional.
- I'd suggest putting a small amount of
padding-right
on the.text
div so that when screens get smaller the text isn't right up against the photo. - I'd also recommend starting to look into BEM naming for your classes. It helps a lot with SCSS nesting when you get deeper into large projects. http://getbem.com/naming/
Keep it up!
David
- I'd suggest putting a small amount of
- @indraAK@dpayne713
Really nice job here. Very pro presentation .
One very small thing I notice.
- the cards on the bottom - if they are going to other parts of a page or another page I like to add
cursor: pointer
to give that feedback to the user that they can click something.
Keep it up! David
- the cards on the bottom - if they are going to other parts of a page or another page I like to add
- @florinpavel22@dpayne713
Hey Florin,
Nice job! this one is deceptively tricky.
- Heads up for Safari browser you will need to give some elements a defined height value for them to not stretch strangely. for example your
.publisher
div would need a defined height as it's currently stretching to 175px of height and messing with the aspect ratio of the picture.
Keep it up!
David
- Heads up for Safari browser you will need to give some elements a defined height value for them to not stretch strangely. for example your