@mattstuddert
Posted
Amazing work on this challenge, David! You've done a really good job. Grace has made some great points for the mobile layout. Your layouts scale up/down really well for different device sizes, so you've done really well on the responsive side of things.
You can also tell you've paid a lot of attention to detail, which is brilliant. I like the added animations and hover effects. They add a nice polished feel to the project!
One thing I noticed on the form is that you use a span
element to give the label/placeholder visual effect. Instead of span
elements, I'd recommend using a label
elements with for
attributes tying each label to the corresponding input
for accessibility purposes. At the moment, people who use screen reader software wouldn't know what each field is for.
I hope that helps. Keep up the great work!
@dpayne713
Posted
@mattstuddert
Thanks Matt, I will change the spans in the form - to be honest it completely slipped my mind!
@mattstuddert
Posted
@dpayne713 no problem!