@bimalmagar10
Posted
@hwang-dolphin Hey! Your built is non-responsive.You should make it responsive as mentioned in the challenge.Also,spacings are not as close to the design.Though, you tried it to make it happen.Happy Coding!🙂
@hwang-dolphin
Posted
@bimalmagar10 thanks for pointing it out. I made some improvements; now it is responsive I guess. But spacings skills will take bit longer, it will take me more practice to get better at spacings.
@bimalmagar10
Posted
@hwang-dolphin Oh! yeah now your built is nearly responsive and I noticed you've added only one break point.🙃
My suggestion for you is that try adding more break points where your design starts to look a bit nasty and non-responsive.And also, you can use relative units like rem
, em
etc. to make your spacings more responsive.Keep practicing, coding and improving.🤟🏻
BONUS 😎
Here is good description and demonstration about responsive designs.If you have a spare time then check it out.😁 You can also check my solution if you want too 😉
@hwang-dolphin
Posted
@bimalmagar10 hello! You have good feedbacks. I haven't had time to work on this project yet, but i did incorporate all your feedbacks in other challenges "interactive pricing component" and the "3 column preview card component". In this challenge, I notice you set "font-size: 1.5rem" in "body". Was "1.5rem" or "15px" chosen because the challenge stated the body font was "15px"? I checked on internet and learned "16px" is equal to "12pt" (Microsoft Word). For me, font size in "pt" then converted to "px" are easier to visualized their size than straight to "px".
@bimalmagar10
Posted
@hwang-dolphin Hey! I only suggested that you should use relative units to make your design more responsive. For rem
it references relative to the root elements font-size i.e in case html
element and for em
it references relative to the parent element's font size.
BTW You should upvote my feedbacks if you like it.😁