@hwang-dolphin
Latest solutions
Latest comments
- @bimalmagar10
@hwang-dolphin Hey! Your built is non-responsive.You should make it responsive as mentioned in the challenge.Also,spacings are not as close to the design.Though, you tried it to make it happen.Happy Coding!🙂
- @MohamedGimmiy@bimalmagar10
@MohamedGimmiy Hey! Everything looks fine and okay to me! One thing I noticed out a bit naive was for mobile navbar.Mobile navbar dropdown is not aligned exactly as in the challenge.In your code, they are aligned from the start instead they must be at the center.Play with some
flexbox's properties to improve those.And also, you should correct down your html and accessibilty issues shown in the report above, so that they count to zero.The rest is exactly fine 😁 - @efecollins@bimalmagar10
Hey, your build isn't responsive at all. Try making it responsive first and for that use relative units like
remas it calculates sizes relative to root element that ishtml.Secondly,position your::beforeelement relative to your phone container in such a way that it is centered at the top within the container. I haven't looked at your code but this might help you. - @Heitoluis@bimalmagar10
Hey! You completed this challenge and that's wonderful. And, I've noticed that your build isn't fully responsive. I viewed your solution using my mobile device with a viewport of 360px width and the texts were overlapping the main container. Try fixing this. The rest is all good.
- @fazar301@bimalmagar10
@fajar Your build is not working properly.Event the search for both keyboard and the button is not working properly.Please find your mistakes and correct it again.And, also you should reorganize your code to look clean.Cheers!
- @okcomputer93@bimalmagar10
@Omar Hey! Your solution is great and the way you wrote your code implementing MVC is great and fantastic to learn.One thing, I suggest you is that you should clear your input field after the 'return' key is pressed or search button is clicked so that it makes easy to input another search without needing to click that cross.And also,you can adjust the width of input field when the browser resizes below 320px. Rest is all good. Happy Coding!
