Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 4 years ago

Room Homepage

bimalmagar•380
@bimalmagar10
A solution to the Room homepage challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I created this design using grid layout.What did you use? Expecting some of your feedbacks!

Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

  • Luca Di Molfetta•365
    @dimolf345
    Posted about 4 years ago

    Hey! It's a wonderful project! I did the same using SASS and GRID. I think CSS Grid is the only way to make this project simple. I haven't seen your code, and since mine has surely more issues than yours, I honestly don't think I can judge it.

    I Just wanted to focus your attention on some things that I noticed:

    • The challenge requires the slider to responds also to user pressing left or right arrow to change images (Take a look at my project if you want);

    • When you change images, something strange happens: the previous one get loaded on the bottom of the page.

    Hope I was useful to you. Happy coding

  • P
    Marko Nikolajević•1,095
    @MarkoNikolajevic
    Posted about 4 years ago

    Hi bimalmagar, you did a great job!

    I noticed that on mobile view the div with class='about__wrapper' goes under the image of the yellow chair.

    For the rest, everything looks good! Congrats and keep on coding!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub