Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Room Homepage

bimalmagar 380

@bimalmagar10

Desktop design screenshot for the Room homepage coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
3intermediate
View challenge

Design comparison


SolutionDesign

Solution retrospective


I created this design using grid layout.What did you use? Expecting some of your feedbacks!

Community feedback

P

@dimolf345

Posted

Hey! It's a wonderful project! I did the same using SASS and GRID. I think CSS Grid is the only way to make this project simple. I haven't seen your code, and since mine has surely more issues than yours, I honestly don't think I can judge it.

I Just wanted to focus your attention on some things that I noticed:

  • The challenge requires the slider to responds also to user pressing left or right arrow to change images (Take a look at my project if you want);

  • When you change images, something strange happens: the previous one get loaded on the bottom of the page.

Hope I was useful to you. Happy coding

1

bimalmagar 380

@bimalmagar10

Posted

@dimolf345 Hey! Thank you for your concern! Yeah just like you said I added the feature to change the slider images with arrow keys.And also,I fixed that strangely happening error when changing the images.It was because of translating the images vertically instead of translating it horizontally. Yeah! and you really was useful to me.Thanks a lot again for your kind response! Happy Coding 😄!

0
P

@MarkoNikolajevic

Posted

Hi bimalmagar, you did a great job!

I noticed that on mobile view the div with class='about__wrapper' goes under the image of the yellow chair.

For the rest, everything looks good! Congrats and keep on coding!

0

bimalmagar 380

@bimalmagar10

Posted

@MarkoNikolajevic Thank you! very much for your concern. Yeah! I reproduced what you actually noticed and figured out what really the problem was.It was because of translating the slider images vertically instead of doin' it horizontally.I probably forgot to correct it before while I was debugging some javascript code.Now,I fixed it correctly.Please have a look! Happy Coding 😃

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord