Skip to content
OverviewSolutions
9
Comments
15
bimalmagar
@bimalmagar10

All comments

  • bimalmagar•380
    @bimalmagar10

    @hwang-dolphin Hey! Your built is non-responsive.You should make it responsive as mentioned in the challenge.Also,spacings are not as close to the design.Though, you tried it to make it happen.Happy Coding!🙂

  • bimalmagar•380
    @bimalmagar10

    @MohamedGimmiy Hey! Everything looks fine and okay to me! One thing I noticed out a bit naive was for mobile navbar.Mobile navbar dropdown is not aligned exactly as in the challenge.In your code, they are aligned from the start instead they must be at the center.Play with some flexbox's properties to improve those.And also, you should correct down your html and accessibilty issues shown in the report above, so that they count to zero.The rest is exactly fine 😁

  • bimalmagar•380
    @bimalmagar10

    Hey, your build isn't responsive at all. Try making it responsive first and for that use relative units like rem as it calculates sizes relative to root element that is html.Secondly,position your ::before element relative to your phone container in such a way that it is centered at the top within the container. I haven't looked at your code but this might help you.

  • bimalmagar•380
    @bimalmagar10

    Hey! You completed this challenge and that's wonderful. And, I've noticed that your build isn't fully responsive. I viewed your solution using my mobile device with a viewport of 360px width and the texts were overlapping the main container. Try fixing this. The rest is all good.

  • bimalmagar•380
    @bimalmagar10

    @fajar Your build is not working properly.Event the search for both keyboard and the button is not working properly.Please find your mistakes and correct it again.And, also you should reorganize your code to look clean.Cheers!

  • bimalmagar•380
    @bimalmagar10

    @Omar Hey! Your solution is great and the way you wrote your code implementing MVC is great and fantastic to learn.One thing, I suggest you is that you should clear your input field after the 'return' key is pressed or search button is clicked so that it makes easy to input another search without needing to click that cross.And also,you can adjust the width of input field when the browser resizes below 320px. Rest is all good. Happy Coding!

  • bimalmagar•380
    @bimalmagar10

    @pikamart Hey! This is totally amazing. Good one and animations are impressive.One thing I pointed out is that the score isn't decremented when we lose the game. This is kinda weird, isn't it? The rest is fine and all good. Happy coding!

  • bimalmagar•380
    @bimalmagar10

    Hey!You did great job building it and your build looks well! If you forgot about how we can center things wihtout flex then here's my reminder for you: -You can center text or inline elements using text-align:center -You can also center the block or inline block elements having a certain width with margin:0 auto -You can center any elements by posiitioning them like posiition:absolute top:50% left:50% and transform:translate(-50%,-50%).This is just a reminder for you.These values may differ with situations you are facing with.And also the element you're centering should be positioned with relative to its parents or any elements i.e they should contain the position:realtive code. This is all about what I know.I hope this may help and get you. Happy Coding!

  • bimalmagar•380
    @bimalmagar10

    Hey! You did a great job and also absolute positioning that point with respect to its container wiil be the best idea to algign it at the end.In addition,flexbox will also be good idea.I also want to say that you should always write the classes with small letters as per the convention . Happy Coding!

  • bimalmagar•380
    @bimalmagar10

    You really did great job building this site.Most of the part is all fine but what i found a bit unusual is:

    • When the window resizes to about 328px then the bookmark button overlaps the back this project button.You can fix that by using flex-direction:column.
    • Also, the out of stock button is clickable which seems totally unusal.You can fix it by setting pointer-events:none as well as cursor:not-allowed.
  • bimalmagar•380
    @bimalmagar10

    Hey!You built it nice and working.Good Job but you can improve it as follows:

    • It would be great if you hadn't console logged the results in the browser when in production mode.
    • It would also be more polished if you had put some nice transitions or animations for the popup results. -And finally,you should try to reduce the accessibilty issues ,as you have 9 issues.

    Happy Coding !

  • bimalmagar•380
    @bimalmagar10

    Hey! John, You did a great job building it.It would be more polished and better if you had used some css transitions in the 'learn more' button.Overall the design looks responsive.Happy Coding!

  • bimalmagar•380
    @bimalmagar10

    Hey! Abdul.It seems all great but it would be better if you had also added changing images with arrow keys which is included in the challenge too. The rest is all good.Happy Coding!

  • bimalmagar•380
    @bimalmagar10

    It would be more better,if input field doesn't take space values.