@hwang-dolphin
Submitted
Feedbacks are welcomed.
Looking to hire developers?
@bimalmagar10
@hwang-dolphin
Submitted
Feedbacks are welcomed.
@bimalmagar10
Posted
@hwang-dolphin Hey! Your built is non-responsive.You should make it responsive as mentioned in the challenge.Also,spacings are not as close to the design.Though, you tried it to make it happen.Happy Coding!🙂
@MohamedGimmiy
Submitted
How can i place images to borders, for example making an overflow to image without making a horizontal scroll.
@bimalmagar10
Posted
@MohamedGimmiy Hey! Everything looks fine and okay to me! One thing I noticed out a bit naive was for mobile navbar.Mobile navbar dropdown is not aligned exactly as in the challenge.In your code, they are aligned from the start instead they must be at the center.Play with some flexbox
's properties to improve those.And also, you should correct down your html and accessibilty issues shown in the report above, so that they count to zero.The rest is exactly fine 😁
@efecollins
Submitted
I had an issue with the ::before
pseudo-element because each time I had to fix the cut-out design at the top of the phone frame, the menu button and the chevron-left button disappears.
Help will be appreciated.
@bimalmagar10
Posted
Hey, your build isn't responsive at all. Try making it responsive first and for that use relative units like rem
as it calculates sizes relative to root element that is html
.Secondly,position your ::before
element relative to your phone container in such a way that it is centered at the top within the container.
I haven't looked at your code but this might help you.
@Heitoluis
Submitted
Your feedback will be much apreciated =)
@bimalmagar10
Posted
Hey! You completed this challenge and that's wonderful. And, I've noticed that your build isn't fully responsive. I viewed your solution using my mobile device with a viewport of 360px width and the texts were overlapping the main container. Try fixing this. The rest is all good.
@fazar301
Submitted
Give me feedback~
@bimalmagar10
Posted
@fajar Your build is not working properly.Event the search for both keyboard and the button is not working properly.Please find your mistakes and correct it again.And, also you should reorganize your code to look clean.Cheers!
@okcomputer93
Submitted
Hi, this is my solution to this challenge, I added some functionality, like shareables URLs through query strings. Any feedback?
@bimalmagar10
Posted
@Omar Hey! Your solution is great and the way you wrote your code implementing MVC is great and fantastic to learn.One thing, I suggest you is that you should clear your input field after the 'return' key is pressed or search button is clicked so that it makes easy to input another search without needing to click that cross.And also,you can adjust the width of input field when the browser resizes below 320px. Rest is all good. Happy Coding!
@pikapikamart
Submitted
This challenge was really fun. My first draft was full of animation but I couldn't pull that one formula in terms of checking boundary so I had to remove it. Limited myself to using only few html elements. So I need to be very careful in my js since i'm just reusing those elements.
Anyway, have a look and drop your comments in my work^^. I will also create the spock version
@bimalmagar10
Posted
@pikamart Hey! This is totally amazing. Good one and animations are impressive.One thing I pointed out is that the score isn't decremented when we lose the game. This is kinda weird, isn't it? The rest is fine and all good. Happy coding!
@opakholis
Submitted
I totally forgot how center or align things without flex :)
@bimalmagar10
Posted
Hey!You did great job building it and your build looks well! If you forgot about how we can center things wihtout flex then here's my reminder for you:
-You can center text or inline elements using text-align:center
-You can also center the block or inline block elements having a certain width with margin:0 auto
-You can center any elements by posiitioning them like posiition:absolute
top:50%
left:50%
and transform:translate(-50%,-50%)
.This is just a reminder for you.These values may differ with situations you are facing with.And also the element you're centering should be positioned with relative to its parents or any elements i.e they should contain the position:realtive
code.
This is all about what I know.I hope this may help and get you.
Happy Coding!
@Gabrieldev-web-coder
Submitted
Please i need your help, in this challenge i think there are better ways to do and i'm not sure that's ok.
For example:
To align the point at the end in bar progress i used (text-align: -webkit-right)
The containers are fixed (static units)
The text space left use position to put in the end of the container, the text of GB left, use position to put at the end of the container i want to that text resize with the progress bar and with of container, but i dont get it, i don't know if that requies javascript or only i don't know it.
All other feedback is welcome! have a nice day! <3
@bimalmagar10
Posted
Hey! You did a great job and also absolute positioning that point with respect to its container wiil be the best idea to algign it at the end.In addition,flexbox will also be good idea.I also want to say that you should always write the classes with small letters as per the convention . Happy Coding!
@olgak169
Submitted
Really enjoyed the JS part of the challenge. Any feedback is welcome!
@bimalmagar10
Posted
You really did great job building this site.Most of the part is all fine but what i found a bit unusual is:
flex-direction:column
.pointer-events:none
as well as cursor:not-allowed
.@kido5285
Submitted
Any feedback is great
@bimalmagar10
Posted
Hey!You built it nice and working.Good Job but you can improve it as follows:
Happy Coding !
@johnrookie-coder
Submitted
Any feedback is highly appreciated for me to grow as a frontend developer. Thanks.
@bimalmagar10
Posted
Hey! John, You did a great job building it.It would be more polished and better if you had used some css transitions in the 'learn more' button.Overall the design looks responsive.Happy Coding!
@abdulrahmancodes
Submitted
Any feedback would be greatly appreciated.
@bimalmagar10
Posted
Hey! Abdul.It seems all great but it would be better if you had also added changing images with arrow keys which is included in the challenge too. The rest is all good.Happy Coding!
@MarcelinaZiolkiewicz
Submitted
Is there anything to improve?
@bimalmagar10
Posted
It would be more better,if input field doesn't take space values.