Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 4 years ago

Rock, Paper and scrissors page with html, css and vanila js

Aw•530
@kido5285
A solution to the Rock, Paper, Scissors game challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Any feedback is great

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Raymart Pamplona•16,040
    @pikapikamart
    Posted over 4 years ago

    Great work on this challenge. The game functions works properly, it's just that the deduction when losing, I think it is not ideal on this one, well that's just for me.

    The animation is bit different and for me, it is kinda making me bit dizzy, since I have a weird thing about animations or things that moves in a fast paced and I have to look at it.

    In terms of layout, it is good and resizes well when switching in mobile version. In the javascript, I can see sections where you can just simplify things up. For example, instead of having to check every player choice and deciding if it is draw. What you could do is just make a section that checks first, if the player and opponent is the same. We could simplify this section;

    if(player === 'scissors') {
         if(opponent === 'rock') {
          result('you lose');    
         } else if(opponent === 'scissors') {
          result('draw');
         } else if(opponent === 'paper') {
          result('you win');
         }
       } else if(player === 'rock') {
         if(opponent === 'paper') {
           result('you lose');
         } else if(opponent === 'rock') {
           result('draw');
         } else if(opponent === 'scissors') {
           result('you win');
         }
       } else if(player === 'paper') {
         if(opponent === 'scissors') {
          result('you lose');
         } else if(opponent === 'paper') {
          result('draw');
         } else if(opponent === 'rock') {
          result('you win');
         }
       }
    

    into

    if(player == opponent) {
        result("draw")
    } else if (player == "scissor") {
       opponent == "rock"? result("you lose"): result("you win");
    }else if (player == "rock") {
       opponent == "paper"? result("you lose"): result("you win");
    }else if (player == "paper") {
       opponent == "scissor"? result("you lose"): result("you win");
    }
    

    Much concise right. Using ternary operator is really great compared to if statements in other scenarios.

    Refactoring js will always be great, always check for equation if there can be a shorthand for it. At the end, still, great job^

  • bimalmagar•380
    @bimalmagar10
    Posted over 4 years ago

    Hey!You built it nice and working.Good Job but you can improve it as follows:

    • It would be great if you hadn't console logged the results in the browser when in production mode.
    • It would also be more polished if you had put some nice transitions or animations for the popup results. -And finally,you should try to reduce the accessibilty issues ,as you have 9 issues.

    Happy Coding !

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub