Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

HTML, CSS

AlbanDavid494•40
@AlbanDavid494
A solution to the Social links profile challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I need comments and review on this guys. thanks for the comment have made changes to my code. have leant something

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • AlbanDavid494•40
    @AlbanDavid494
    Posted over 1 year ago

    Thanks alot. Let me work on it immediately

  • Anyona Zaddock Ogada•190
    @zacc-anyona
    Posted over 1 year ago

    Hello @AlbanDavid494, Your solution is good, but there are some few areas you can improve on.

    • Your page is not well landmarked. For example the div element with class attribution you could have enclosed it with <footer></footer>. Footer element is used to display author information, contact details. It is normally found at the bottom. But your author details are appearing at the top of the page.

    • Responsiveness. Your page is not that responsive especially for mobile devices. Consider reformatting your media query to;

    @media screen and (max-width: 600px) 
    /*for smaller screens have a standard a width of 600px*/
    
    • The challenge was about social media links. Consider to add <a href=""></a> to your buttons.

    Other than that you have done a great job in completing this challenge.

  • Lahan•210
    @lahanhelith
    Posted over 1 year ago

    Hey man!

    You have done an OK job with your solution but it seems you had trouble centering it horizontally and vertically. For this, you can use CSS Flexbox on the body by using this code in CSS.

    body{
    display:flex;
    margin:0;
    min-height:100vh;
    align-items:center;
    justify-content:center;
    }
    

    If you have no idea about what Flexbox is or how you can work with it you can watch this video which explains the concept quite clearly.

    Also, there are some things you can change within your HTML such as using a <main> element to contain your card content which does not impact how it looks and using an <h1> tag with a reduced font size which aids in SEO.

    Furthermore, it is possible to make the card look responsive on all screen sizes without using a media query which I would suggest you try to achieve.

    Good Luck with your Frontend Journey!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub