Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML, CSS

@marawanmohamed9876

Desktop design screenshot for the Single price grid component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


how do I solve my issue in this code?

Community feedback

P
ApplePieGiraffe 30,545

@ApplePieGiraffe

Posted

Hey, Marawan Mohamed! 👋

Nice job! 👍

I suggest,

  • Decreasing the font-size in the desktop layout (it's quite big at the moment).
  • Rounding the corners of the component a little (like the original design).

Keep coding (and happy coding, too)! 😁

1

@marawanmohamed9876

Posted

@ApplePieGiraffe Thank you for your feedback, I will make these changes now and happy coding to you also 😁

0
Roman Filenko 3,335

@rfilenko

Posted

Hey, what issue are you implying to ? Here some fixed and improvements you can do:

  • don't use id's for styling;
  • it's better not to set margin, padding in %;
  • set max-width instead of just width on some containers.

Cheers, Roman

1

@marawanmohamed9876

Posted

@rfilenko thank you for your feedback. I will make these changes

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord