Amon• 2,560
@A-amon
Posted
Hello! It looks good and so is the responsiveness~
I have a few suggestions:
-
Instead of changing image's color in JS by switching images, try using SVG images. This way, you can change the image's fill property in CSS on hover.
-
Listen to "submit" event instead of "keyup" when handling form submission. P.s. Add event.preventDefault() when doing that, so that it doesn't reload the page upon submission.
-
Add classes to classList instead of directly setting the styles in JS. Then, set the styling for the class in CSS. This way, CSS logic will stay within CSS and JS' within JS.
Marked as helpful
1
