Vanza Setia• 27,855
@vanzasetia
Posted
👋Hi Prajwal Gautam!
I have some feedback on this solution:
- For best practices, I recommend to set your tab size to
2
, that way your code is more easy to read. It's also a common practice. - The
alt
value for the logo should be the company nameHuddle
. - For any decorative image, you should leave the
alt=""
and addaria-hidden="true"
to make screen reader ignore the image. In this case the illustration image is just decorative image. - The
aria-label
for the link do not needGo to
, just the social media platform. Screen reader will pronounce it as a link as long you are using thea
tag. - Use
rem
or sometimesem
instead ofpx
. Usingpx
won't allow the users to scale the size based on their needs.
That's it! Hopefully this is helpful!
0
Prajwal Gautam• 190
@prajwal18
Posted
@vanzasetia i like the tab size to be 4
maybe i will change it to 2 in the future, apart from that everything else i will implement it.
Thanks for the feedback
0