HTML CSS

Solution retrospective
Can someone review my work and give feedback, best practices, how you would do certain aspects differently. Any feedback would be highly appreciated.
Please log in to post a comment
Log in with GitHubCommunity feedback
- @vanzasetia
👋Hi Prajwal Gautam!
I have some feedback on this solution:
- For best practices, I recommend to set your tab size to
2
, that way your code is more easy to read. It's also a common practice. - The
alt
value for the logo should be the company nameHuddle
. - For any decorative image, you should leave the
alt=""
and addaria-hidden="true"
to make screen reader ignore the image. In this case the illustration image is just decorative image. - The
aria-label
for the link do not needGo to
, just the social media platform. Screen reader will pronounce it as a link as long you are using thea
tag. - Use
rem
or sometimesem
instead ofpx
. Usingpx
won't allow the users to scale the size based on their needs.
That's it! Hopefully this is helpful!
- For best practices, I recommend to set your tab size to
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord