Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML, CSS e JS

@JosueLauren

Desktop design screenshot for the Ping single column coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Qualquer feedback, será bem vindo.

Community feedback

Amon 2,560

@A-amon

Posted

Hello! Great work~ It has good responsiveness.

I have a few suggestions (I think?)

  1. The logo image should be wrapped by an a tag that links to the homepage.

  2. I am not sure about putting the heading till the form elements in the header but this is just my preference, I guess.

  3. Putting the section in a main tag should remove some of the accessibility issues in the report.

  4. Have an aria-label attribute in your a tags for footer. https://www.w3.org/WAI/WCAG21/Techniques/aria/ARIA8.html#:~:text=The%20aria%2Dlabel%20attribute%20provides,used%20instead%20of%20aria%2Dlabel%20.

  5. Instead of setting the styles directly in JS, add/remove class instead. E.g. add .success class to show success-related styles.

  6. I think there should be a label or aria-label for the input element.

Marked as helpful

0

@JosueLauren

Posted

@A-amon Obrigado pelas sugestões !!!

0
Amon 2,560

@A-amon

Posted

@JosueLauren Glad to help!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord