Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 5 years ago

HTML, CSS, Flex-box for responsive design

Victor Bruce•140
@victorbruce
A solution to the Social proof section challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I've made the finally changes after some fantastic feedback from the community. Thank you everyone ❤️.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • ApplePieGiraffe•30,525
    @ApplePieGiraffe
    Posted over 4 years ago

    Great job, Victor Bruce! 👍

    Just one last thing in addition to the wonderful feedback you already have—setting a max-width on the main container or wrapper will ensure that the content of the page doesn't look too stretched on large screens (although this design still looks pretty good when the screen width increases). 😉

    Keep coding (and happy coding, too)! 😁

  • Grace•32,130
    @grace-snow
    Posted over 4 years ago

    Hi Victor

    Good job on this, it looks nice on all screen sizes!

    A few larning points for next time:

    1. Only include alt text on images that have meaning, otherwise leave the alt text blank. e.g. when I turn images off for your page, I get reviews rate star reviews rate star reviews rate star reviews rate star reviews rate star Rated 5 Stars in Reviews - as you can see, the alt text on the images adds no meaning there and should be alt="" to demonstrate it's intentionally blank

    2. Remember with CSS grid that it is for 2 dimensional layouts. With a minor adjustment to your html markup, your .card elements could easily be one grid rather than just the card header.

    3. I would advise against setting your html size to be small. There is little reason to do this and forces you to then change font sizes throughout a project. Not a big problem on a little challenge like this, but it could cause big issues on a large project where rems and ems are then used to size elements.

    Hope all that's helpful :)

  • Emmilie Estabillo•5,600
    @emestabillo
    Posted almost 5 years ago

    Hi Victor, congrats on finishing this challenge! Here are a few points:

    • I'm looking at the mobile view and I'm not seeing all of your project because body has height: 100vh on it.
    • The testimonial cards can also use max-width to control the stretch - they look really wide on medium-sized screens.
    • At 769px, the last ratings div is touching the gutter. Maybe it's better to keep them all in a straight line and indent them when you have more space
    • The testimonial cards could use some margins or gaps in between them around 1025px to 1370px

    Hope this helps :-)

  • Jazy•15
    @jazy-bhai
    Posted almost 5 years ago

    https://www.w3schools.com/css/css3_backgrounds.asp

    I was facing the same problem. This helped me. I hope this helps you too !

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub