Skip to content
Submitted almost 4 years ago

HTML | CSS (Flexbox) | Vanilla JS

Pierpaolo Pascarella•140
@Pierpaolo01
A solution to the Rock, Paper, Scissors game challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

2cnd project completed, I'm very happy with the design, but I feel like alot of the JS code I wrote is very repetitive w/ creating alot of elements from within JS to show the final outcome,

I will try to stream line that code more so it can be more efficient, any comments welcome !

Code
Couldn’t fetch repository

Please log in to post a comment

Log in

Community feedback

  • Mojtaba Mosavi•3,740
    @MojtabaMosavi

    Take look at the following things:

    1- There is alot of rum to improve the markup, writing semantic markup is all about chosing the right html elemen for the content contained within it. You use alot of div where there are much more semantic html elements.

    2- This is only my a suggestion, make the result section a two row layout because at the moment they are stacked next to each other thightly.

    Well done.

    Keep coding :=)

  • P
    Patrick•14,265
    @palgramming

    The You win You loose text is not showing up the same place as the You Tied notification is. The you Win you Lose is showing up to the right of the game pieces and the Tied is showing up below the game pieces as it looks like they should

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord