Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML, CSS, JS

elalmamia 90

@elalmamia

Desktop design screenshot for the FAQ accordion card coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi, I'm a newbie so I would appreciate any feedback:)

Community feedback

P
tediko 6,580

@tediko

Posted

Hello, elalmamia! 👋 Well done on this challenge! It is really well done. I really like the box animation on hover.

  • Try to work on the proper class naming. Your classes aren't descriptive and also hard to read in the code. One of many benefits of proper class naming is that you know what to expect from a certain class without looking at code, even if you aren’t the person who created it or if it was written a long time ago. The name of a selector should be self-descriptive and readable. For example .card-right can be name .accordion etc.
  • Add :focus pseudo class to interactive elements like anchors, buttons and inputs in your case. Use outline property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default :focus pseudo class with outline property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles.

Keep up the good work! 💪

0

elalmamia 90

@elalmamia

Posted

@tediko Thanks for the hints! Really appreciate it!

0
P
Patrick 14,325

@palgramming

Posted

Looks good ⭐⭐⭐⭐⭐

0

elalmamia 90

@elalmamia

Posted

@palgramming thank you!

0

@AbePlays

Posted

Definitely doesn't look like a newbie's work. Good job!

0

elalmamia 90

@elalmamia

Posted

@AbePlays Nice to hear that. Thank you!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord