Hello, elalmamia! 👋 Well done on this challenge! It is really well done. I really like the box animation on hover.
- Try to work on the proper class naming. Your classes aren't descriptive and also hard to read in the code. One of many benefits of proper class naming is that you know what to expect from a certain class without looking at code, even if you aren’t the person who created it or if it was written a long time ago. The name of a selector should be self-descriptive and readable. For example
.card-right
can be name.accordion
etc. - Add
:focus
pseudo class to interactive elements like anchors, buttons and inputs in your case. Useoutline
property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default:focus
pseudo class withoutline
property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles.
Keep up the good work! 💪
0
elalmamia• 90
@elalmamia
Posted
@tediko Thanks for the hints! Really appreciate it!
0