Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

HTML, SASS, JAVASCRIPT

sass/scss
Neha Nalini Kennedy•100
@nehanalinik
A solution to the FAQ accordion card challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Can anyone tell me how to not allow overflow:hidden to the box image in the desktop view?

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Anosha Ahmed•9,300
    @anoshaahmed
    Posted over 3 years ago

    wrap everything in your body in <main> ... OR use semantic tags! .... you can also give role="" to the direct children of your <body> but that's a little frowned upon... Click here to read more

    Great job Neha! :)

    Marked as helpful
  • Ren Ras•420
    @renras
    Posted over 3 years ago

    You have overflow property set to hidden on your "images" class. You can nest the box inside your main container instead if you're trying to overlap it.

    Marked as helpful
  • Stefan•730
    @stfnpczk
    Posted over 3 years ago

    Well done Neha, your solution looks very good and responds well. In order to prevent the box to be cut off, you can place the box in a different container than the images of the shadow and the woman. I suggest you also put position: relative on that separate container so the box doesn’t move around with different screen sizes.

    Once again, well done and happy coding.

    Marked as helpful
  • Remus D. Buhaianu•3,125
    @remusbuhaianu
    Posted over 3 years ago

    Congrats on completing the challenge, @nehanalinik!

    Your solution looks quite good. I have a few suggestions that I hope will be useful:

    • Try to reduce the amount of shadow that you have set on your main container

    • Your container's height shouldn't increase / decrease whenever an accordion is opened / closed

    • You don't need to use a forEach to get the accordion effect working. Try using event delegation to simplify your code https://dmitripavlutin.com/javascript-event-delegation/

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub