@ApplePieGiraffe
Posted
Greetings, Roc Tanweer! π
I know I'm very late to this challenge! π I just saw your comment requesting for feedback on my solution for this challenge today (I think you might have accidentally mentioned your username in the comment instead of mine, which is why I didn't get notified)! π But anyways, now that I've seen your solution, I can say I think you've done a wonderful job on this challenge! π
The little animations that you added around your solution are very nice and the to-do list itself looks good and works well! π Great attention to detail! π
The only very small suggestion I have is to give your document a title using the <title>
tag. π
And also, don't forget to take a look at your solution report and try to clear up some of the errors that are there. There seem to be a few duplicate IDs (that should be easy to remove) and for the rest of the errors, don't forget to prefix any custom attributes that you add to HTML elements with data-
(if that's the reason for the completed
attributes on some <div>
s).
As for the "delay" between when the page is resized and the fluid typography adjusts in font-size, you might want to remove the transition
on the text on the page (since that isn't necessary) so that they respond to changes in the size of the viewport faster. π
Hope that helps. π
And as alwaysβkeep coding (and happy coding, too)! π
@RocTanweer
Posted
@ApplePieGiraffe he he he he
I forgot to change the title name..!
Yeah about those issues, I didn't know about data attributes when I was building this that's why I used completed
and duplicated ids
(I will fix that when I will get the time π
)
This project was quite big for me so I forgot to see some of the things(That's why we need feedback)
Thank you for your feedBack and I will fix all of them ASAP..!
Yeh! happy coding too!π
@RocTanweer
Posted
@ApplePieGiraffe Off the Topic...
- I created a repo by drag n drop method at GitHub.
- Now, after a couple of weeks, I wanna get those files from the repo to local machine(in case files get deleted from local machine)
- I changed the some of the files.
- Now when I am pushing, It is saying compare and merge pull request.
- I do not wish to make pull request to my own account.
- I did made 3 PRs by mistake first, and it increased PR data of my account on my profile(which is not what I wish)
- Obviously, I wish to increase my PRs data but when I am contributing to open source or to someone else, not like this.
Any Idea how to make changes without making a pull request?
Or if not possible...
how can I hide PRs and avoid adding it to the profile data?
@ApplePieGiraffe
Posted
@RocTanweer
Hmm... I'm not a Git or GitHub wizard (sometimes, these things confuse me, too) but... are you on the master
branch of your Git repo? Perhaps you switched to another branch and that's why Git is asking you to compare and merge things (but IDK why it's asking you to make a pull request). π§ Maybe check if you're on the master
branch and bring over any changes from other branches that you need to and then push that to the remote repo. π
@RocTanweer
Posted
@ApplePieGiraffe Nope, You are a wizard
problem solved
Thank you..!
@ApplePieGiraffe
Posted
@RocTanweer
Haha, okay! Cool! π