HTML Sass Vanilla JavaScript Vs Code

Community feedback

• 

  Anna Leigh•5,135

  @brasspetals

  Posted over 4 years ago

  Hi, RocTanweer! 👋

  • The layouts at specific media queries look great, and you’ve clearly put in a lot of thought into them. Ideally, however, your solution would look good on all screen sizes, not just a handful of set widths. I would suggest in future projects to focus on responsive design. I see you’ve used a bit of Flexbox, which is great! I encourage you to dig deeper into it, as it’s great for responsiveness. Grid is also really good, but I’d learn one at a time as to not get yourself too confused in the process. Here’s a really nice resource for Flexbox that also has some great links at the bottom of it. For image responsiveness, I’ve found a width percentage combined with a max-width usually works pretty well. The object-fit property can also be really useful. There’s also picture and figure elements, although I still have a lot of learning to do about those myself. 😄

  • Another great resource is this admittedly long article on semantic html. I refer back to often, and I’ve found it really helpful for my projects.

  • For the errors in your report, adding title tags inside the svg of your social icons should clear them up. Here’s an example:

  <a href=“#”
        <svg…
          <title>instagram</title>
           <path>…
  

  I realize this feedback isn’t picking out specific elements, but I hope it’s still helpful! Happy coding!

  23
• 

  Moses•65

  @consolexyz

  Posted over 4 years ago

  The mocks up is not positioned well oj Mobile devices 375px

  11