Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML5, CSS3

@ASlawinska

Desktop design screenshot for the Insure landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


I have problem with changing hamburger buttom for close buttom in mobile version. If some one help me with that I will be very glad :)

Community feedback

@shubhamthedev

Posted

Okay i see that you've posted a new solution but you could as well update your previous solution by changing the source of your repository. Anyways the hamburger is usually made using JavaScript although i sometimes use something known as a checkbox hack which you could learn more about here: Checkbox Hack this doesn't require JavaScript.

As for the code you've written, I'll be honest i really couldn't understand how you've implemented it since hovering over the header displays the drop-down and in my opinion you would probably need to write a JavaScript function for that.

You could learn about it W3S.

2
Adarsh Pratap 5,515

@adarshcodes

Posted

Hey! @ASlawinska, good job. It's a great start. Let's find out what we can learn with this community🙂

  1. Design aspect
  • Your overall design looks fine but needs a few changes.
  • Increase the font-size of main-heading by a few px.
  • Increase the z-index of your first button and also decrease its padding-top and bottom a bit.
  1. Responsiveness aspect
  • Responsiveness works fine, just decrease the font size of the middle section heading.
  • Add some margin-right to 'we're different cards'
  • For the hamburger menu, you can try the above solution provide or try this one: https://www.youtube.com/watch?v=F-mvXKKoSCU
  1. Code aspect
  • Your code is pretty clean and well-commented👏.
  1. Issues aroused
  • Try to solve the HTML issue.

You had a great start👍, keep it up, keep learning, keep coding🐱‍💻

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord