Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 4 years ago

HTML,CSS, responsive design

Artem Marchenko•50
@ArtemVMV
A solution to the Order summary component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hey everyone! Just starting, hope that's vital =D

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Mike Hayden-Moore•1,005
    @mickyginger
    Posted almost 4 years ago

    This is really well done Artem! 🎉

    You could improve things a little by using some semantic HTML tags. For example you have <div class="header"> and <div class="article"> where you could (or should) use <header> and <article> respectively.

    Here's a good article about semantic HTML for you to have a look at: https://www.freecodecamp.org/news/semantic-html5-elements/

    Another thing I noticed is that your code is poorly formatted, so the opening and closing tags don't line up and there's lots of whitespace that should be removed. This makes it more difficult to read through and review your code.

    I would advise you use a code formatter that will automatically format your code for you, so you don't have to worry about it! Prettier is my favourite. Most code editors like VSCode and Sublime Text come with Prettier plugins.

    Hope that helps!

    Marked as helpful
  • Erick F. Felix•265
    @efs0-cod3
    Posted almost 4 years ago

    Good solution Artem. I would remove the line-height and font-weight on .article for more aesthetics.

    good luck!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub