HTML,CSS,JS

Community feedback

• 

  Shashree Samuel•8,860

  @shashreesamuel

  Posted over 3 years ago

  Hey good job completing this challenge

  Keep up the good work

  Your solution looks great however I think that your divider line needs some margin from the bottom using margin-bottom.

  In terms of accessibility issues simply wrap all the content between main tags

  I hope this helps

  Cheers Happy coding 👍

  00

  Marked as helpful
• 

  

  Chamu•13,820

  @ChamuMutezva

  Posted over 3 years ago

  Greetings Athreya.

  You have done well with this challenge, well done. However, i noted that clicking the dice does not generate a new quote. Only after refreshing is when i get a new quote. Always use semantic elements where possible, that will help to make your site accessible. One particular case is when you used a div instead of a button for interactive purposes - a div will require a whole lot more code to make it accessible, as a keyboard user i am not able to use it.

  • a site should also have a heading element , with an h1 being the first heading element of your site, thereafter heading elements should then follow a sequential order without skipping headings.
  • the site is responsive , good job.

  00

  Marked as helpful
• Account deletedPosted over 3 years ago

  Hello there! 👋

  Congratulations on finishing your challenge! 🎉

  I have some feedback on this solution:

  • put the quote inside a <blockquote> tag instead of span to be more semantic

  • check the HTML report to fix accessiblity issues

  i hope this is helpful and goodluck

  00

  Marked as helpful