Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML,CSS,JS

Athreya Gā€¢ 410

@AthreyaG4

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Comments welcome.

Community feedback

Shashree Samuelā€¢ 9,260

@shashreesamuel

Posted

Hey good job completing this challenge

Keep up the good work

Your solution looks great however I think that your divider line needs some margin from the bottom using margin-bottom.

In terms of accessibility issues simply wrap all the content between main tags

I hope this helps

Cheers Happy coding šŸ‘

Marked as helpful

0
P
Chamuā€¢ 12,970

@ChamuMutezva

Posted

Greetings Athreya.

You have done well with this challenge, well done. However, i noted that clicking the dice does not generate a new quote. Only after refreshing is when i get a new quote. Always use semantic elements where possible, that will help to make your site accessible. One particular case is when you used a div instead of a button for interactive purposes - a div will require a whole lot more code to make it accessible, as a keyboard user i am not able to use it.

  • a site should also have a heading element , with an h1 being the first heading element of your site, thereafter heading elements should then follow a sequential order without skipping headings.
  • the site is responsive , good job.

Marked as helpful

0
Oldā€¢ 6,220

@Old1337

Posted

Hello there! šŸ‘‹

Congratulations on finishing your challenge! šŸŽ‰

I have some feedback on this solution:

  • put the quote inside a <blockquote> tag instead of span to be more semantic

  • check the HTML report to fix accessiblity issues

i hope this is helpful and goodluck

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord