@vanzasetia
Posted
Hello, Parvathy! 👋
Congratulations on completing your first Frontend Mentor challenge! 🎉 Your solution looks pretty good! 😀
About the social media icons, I would highly recommend removing the !important
flag to change the color of the icons on :hover
and :active
states. The hover state is still working even without the !important
. So, I highly suggest avoiding using !important
whenever you can.
Also, I recommend wrapping all the social icons with anchor tags instead of a div
. It's important that a link element should be wrapped by the link element (not a div
or anything else). Right now, the screen reader users don't know that there are social media links of the company.
I have some feedback on this solution:
- Alternative text for images should not contain any words that related to image (e.g. picture, photo, logo, icon, graphic, avatar, etc). It's already an image element so the screen reader will pronounce it as an image.
- For the logo, the alternative text should be the company name, in this case, Huddle.
I hope you find this information beneficial. Happy coding! 😄
Marked as helpful
@parvathyvd
Posted
@vanzasetia
Thanks a lot for this helpful review. I will make sure those things are take into account. I really appreciate that you took time to review it.
Thanks 🙏
@vanzasetia
Posted
@parvathyvd You're welcome! 👍