Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Huddle landing page hero section

@parvathyvd


Design comparison


SolutionDesign

Solution retrospective


I couldn't able to change the hover color of the social media icons even though i changed it on hover in the css. I believe may it because the font icon itself? I took them from font-awesome-icons. Please feel free to let me know what's wrong with it

Thanks

Community feedback

Vanza Setia 27,855

@vanzasetia

Posted

Hello, Parvathy! 👋

Congratulations on completing your first Frontend Mentor challenge! 🎉 Your solution looks pretty good! 😀

About the social media icons, I would highly recommend removing the !important flag to change the color of the icons on :hover and :active states. The hover state is still working even without the !important. So, I highly suggest avoiding using !important whenever you can.

Also, I recommend wrapping all the social icons with anchor tags instead of a div. It's important that a link element should be wrapped by the link element (not a div or anything else). Right now, the screen reader users don't know that there are social media links of the company.

I have some feedback on this solution:

  • Alternative text for images should not contain any words that related to image (e.g. picture, photo, logo, icon, graphic, avatar, etc). It's already an image element so the screen reader will pronounce it as an image.
  • For the logo, the alternative text should be the company name, in this case, Huddle.

I hope you find this information beneficial. Happy coding! 😄

Marked as helpful

0

@parvathyvd

Posted

@vanzasetia

Thanks a lot for this helpful review. I will make sure those things are take into account. I really appreciate that you took time to review it.

Thanks 🙏

0
Vanza Setia 27,855

@vanzasetia

Posted

@parvathyvd You're welcome! 👍

0
Nakoya Wilson 1,530

@nakoyawilson

Posted

I downloaded your code and after experimenting with it, it seems the color property in this rule is affecting the hover state:

*,
::after,
::before {
  ...
  color: #fff;
}

If you remove it from there and put it in the body for instance, the social media icons will change color on hover.

Marked as helpful

0

@parvathyvd

Posted

oh ..Thanks a bunch. I might have accidentally added that in the pseudo class. Thanks for pointing it out. That was fast! I really appreciate it.

Thanks :)

0

Nakoya Wilson 1,530

@nakoyawilson

Posted

@parvathyvd You're welcome.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord