Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Huddle Landing Page SCSS BEM

#sass/scss#bem
Hipp0Fir3 310

@VladAvram232323


Design comparison


SolutionDesign

Solution retrospective


Hi everyone! I have some questions about this solution. First, I dont know why the page is scrolling even if I added height:100vh. Second, any suggestion on a good way to add these background svg and look proper? Third, I think I go too hard on naming with BEM, sometimes it become too chaotic.

Community feedback

P

@12Kentos

Posted

Hey @VladAvram232323,

Nice job on this challenge, it looks really good! I'm assuming you are talking about scrolling up and down not left to right? If so one thing you could add to your code is to change height: 100vh; to max-height: 100vh; As this would limit the screen to the 100vh and won't let it get bigger than that.

Secondly I'm not sure what you mean by adding the background svg to look proper, I might be missing something but they seem fine to me?

Lastly, unfortunately with BEM I struggle with this as well. I recently posted in the slack asking the same question, and this was the response I got.

"Naming things is famously one of the most difficult things in programming. I guess it's just practice at breaking apart layouts into meaningful chunks. If you struggle to come up with a name for a chunk, maybe it's not its own discreet thing and you need to think about a slightly bigger piece of the layout."

hopefully that helps. One thing I do know, and I've been told over and over again, is the more you practice at it, the easier it will become.

Good luck on your future projects!

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord