Huddle Landing Page using HTML, Sass

Community feedback

• 

  

  ApplePieGiraffe•30,525

  @ApplePieGiraffe

  Posted about 4 years ago

  Hey, Siddhesh Kamble! 👋

  Nice work on this challenge! 🙌 Your solution looks pretty good! 😀 Also, kudos for trying out Sass (it is very nice and makes writing CSS easier). 👍

  I'd just like to suggest adding background-size: cover to the background image so that it fills the entire area of the screen but doesn't get stretched or squeezed when the size of the screen changes. 😉

  You could also try allowing the width of the image to be determined by the size of the screen in the mobile layout (by adding width: 100% to the image or its container or something) so that you don't have to use a media query to change the size of the image twice for the mobile layout. 🙂

  Keep coding (and happy coding, too)! 😁

  13

  Marked as helpful
• 

  Vanza Setia•27,715

  @vanzasetia

  Posted about 4 years ago

  👋Hi Siddhesh Kamble! My name is Vanza!

  One thing on your style.scss, in my opinion, next time you can just do:

  background: url(../images/bg-mobile.svg), $violet;
  

  Rather than this:

  background: url(./../images/bg-mobile.svg), $violet;
  

  Because in my opinion, it's just kinda redundant, since it's just doing the same thing.

  That's it! Hopefully this little tip may useful for you!

  02

  Marked as helpful