@elroytoscano
Posted
Hi Catherine, good job with the design and not getting any Accesibility and HTML issues.
Here are some areas you could improve:
- The original design has a padding of certain units all around(maybe 6 or 8rem), the positioning of the social media icons breaks that alignment.
- In case you're making a circular button, in the styling the width and height should be the same. The facebook icon is elliptical, after checking through your code, the media-icon class should have the same height and width,(32px -width and 38px height is causing the elliptical structure), whereas twitter and insta icons are perfect.
- When hovering over any button/link,
cursor:pointer
and subtle change inbackgroundColor
provide a good visual feedback to the users.
Hope this helps.
@catherineisonline
Posted
@elroytoscano Thank you for the feedback, much appreciated!