Huddle Landing Page challenge on Frontend Mentor

Solution retrospective
Had fun building this project. Love to get some feedback.
Please log in to post a comment
Log in with GitHubCommunity feedback
- @Hassiai
Replace <a href="#"><i class="fab fa-facebook-f"></i></a> with <a href="#" class= "fab fa-facebook-f"></a>, repeat this for all the social media icons to fix the error issue.
<p class="attribution"> should be in the footer tag not outside the footer tag, to fix the accessibility issue. for more on semantic html visit https://web.dev/learn/html/semantic-html/Use rem or em as unit for the padding , margin, width and preferably rem for the font-size for more on this watch this https://youtu.be/N5wpD9Ov_To
Hope am Helpful. HAPPY CODING
Marked as helpful - @eewa-SANJ
Hello! Your solution is pretty nice. Here are some of my issue findings and suggestions.
- You can't use CSS-reserved keywords inside the class name. Your used <div class="flex"> this one. The error will not give but its not good practice
- You use mix of rem and px units, I suggest you use one unit in order to maintain consistency
- I notice that small screens and background patterns are repeated through the x-axis, so it is not mentioned in the design files. Tyr to fix it using background-size property and background-repeat property
Overall your solution is amazing and clean. I think above mention suggestions will help you
Happy coding😊
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord