@kenreibman
Posted
Great job on the use of proper HTML5 semantics tags, and the use of rems!
Since you already have a good understanding of not using px and instead using rems, I'm going to send you this article that might be interesting for you to read.
Although I really recommend you to read it, summarized, the article talks about the benefits of setting the base font-size to 62.5% which basically makes 1rem = 10px. Something you were already close to doing!
Now you might see the pattern, and how rems become much easier to handle. If you want a 255px container, just set it to 25.5rem.
From experience, I also suggest giving classes to your heading tags specific names instead of leaving it as h1 so it's easier for someone going over your work to understand what is going on.
I hope this helps, and keep it up!
Marked as helpful
