γγ¬γ³γΏγ€γ³ πβ’ 64,190
@VCarames
Posted
Hey there! π Here are some suggestions to help improve your code:
- Your "buttons" were created with the incorrect element. When the user clicks on the button they should directed to a different part of you site to sign up. The
Anchor Tagwill achieve this.
- The
articleelement is not needed in this challenge, since nothing is site is independently reusable.
- The βIllustrationsβ serve no other purpose than to be decorative; They add no value. Their
Alt Tagshould left blank and have anaria-hidden=βtrueβto hides it from assistive technology.
- The "Ready To Build Your Community?" should be a
h2heading.
- As mentioned by the other user, the
footerβphoneβ and βaddressβ should be wrapped inAnchor Tags, so users can easily click on them and have the appropriate app open for them.
- The
footerlinks need to be wrapped inside anavelement and should only be one single list.
- The βsocial media iconsβ are not decorative, they need to have an
Alt Tagwith a description.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! ππ¦
Marked as helpful
2
πΎ Ekaterine Mitagvaria πΎβ’ 7,640
@catherineisonline
Posted
@vcarames Thank you for the feedback! Some questions:
- Where did you see that buttons are anchor tags? What if they open a modal window for registration, for example?
- Are articles used only for reusable blocks of code? I thought they separated the logic.
- Same questions regarding "Ready To Build Your Community?" being h2, is there a way to understand when it's h2 and when h3?
Thank you
0
γγ¬γ³γΏγ€γ³ πβ’ 64,190
@VCarames
Posted
@catherineisonline
- While a modal can work, having a dedicated page for for signs up, will provide you with more flexibility than a modal and depending on company they might use a third party authentication system, that will require a a redirect. But if it's simple, like asking users an email and password, a modal will be fine.
- Reusable not just on your own site but also on other sites, think Yahoo, Ads, etc...
- It's a CTA section, so it hold a high ranking level. The
h2creates the sections of you site (think book chapters). Whileh3headings are for sub-sub-sections. For example, a section giving reason why a user should join:
<section>
<h2>Why Join</h2>
<p>
Lorem ipsum, dolor sit amet consectetur adipisicing elit. Dolor, sit
deserunt!
</p>
<ul>
<li>
<h3>Lorem ipsum</h3>
<p>dolor sit amet consectetur adipisicing</p>
</li>
<li>
<h3>Lorem ipsum</h3>
<p>dolor sit amet consectetur adipisicing</p>
</li>
</ul>
</section>
Marked as helpful
2
πΎ Ekaterine Mitagvaria πΎβ’ 7,640
@catherineisonline
Posted
@vcarames Makes sense, thanks ππ»
2
