Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Huddle landing page with Flexbox and CSS

Kim 340

@Mismisty


Design comparison


SolutionDesign

Solution retrospective


I welcome all feedback so please take a look at my code and tell me what you think. Also, I have trouble with the mobile responsiveness. Can someone tell me what I'm doing wrong?

Community feedback

@tesla-ambassador

Posted

Great solution, it looks really neat! Here's a few pointers you might want to consider though:

  • You might want to add the font awesome icon attributes in a <i class="your_icon_classname">...</i> and then contain them within your <a></a> tags to solve some of your accessibility issues.
  • You should also contain your divs within landmarks like <main>...</main> or <section>...</section> (it's good practice and helps with accessibility).
  • For better design practices, you should change the color of your attribution links to something visible that doesn't clash with the background for your case you could try something like gray or white or anything a lighter than the background.
  • You also need to add a few more break-points in your media queries, yours start at a screen with a max-width of 600px and there are some other screens with bigger sizes but relatively smaller to those of a desktop forexample some screens could be 840px so you should consider making it responsive at a screen width between 600px and 1440px therefore you should consider adding more break points between then. This is really good work, Happy coding!
0

@caarlosdamian

Posted

Awesome work !!!! looking very sharp congratulations, just some little comments, go to your report and check that you missing you alt attributes on your <img alt='somthing'/> tags this help the browser on getting more information an gain more accessibility to the end-user overall good job keep it pushing

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord