Hi Shubham!, Great work on this project! just a few suggestions
-
I noticed the design breaks a bit when it gets to
914px
I would suggest the media query break point to be before then. -
I see within your code you use the
header
tag to wrap your whole content. Probably just a preference thing, but I usually use theheader
tags for menu-like content like nav bars, and logos. Then I would use either themain
tag or asection
tag for regular content. -
The last thing I noticed is that there is a
script
tag at the top, inside thehead
tag. It's best practice to place anyscript
tags at the bottom of the page, namely right above the ending</body>
tag. That way when the browser runs, it loads the content first then any JS scripts.
Other than that, again great job! :) keep up the good work.
P.S. Hope this makes sense
@shubhamthedev
Posted
@AjeaSmith hey thanks for the feedback, I will probably fix the 914px break-point and yes i prefer <nav>
for navigation and <header>
for the first page and I've placed the
tag in the head because font awesome gives weird validation errors if placed at the end.