@pikapikamart
Posted
Hey, awesome work on this one .Desktop layout looks great, it is responsive and the mobile state looks great. Though your breakpoint of 1100px, is that right? Is too big for all the mobile layout to occupy, since desktop layout could use more of those. So adjusting the breakpoint would be really great.
Some other suggestions would be:
- Avoid using
id
to target and style an element since it is a bad practice due to css specificity. - The hero-section image could be hidden for screen-reader users since the image does not look meaningful and only acting as decoration. Decorative images should be hidden for screen-reader at all times by using
alt=""
andaria-hidden="true"
to theimg
tag or onlyaria-hidden="true"
if the image is usingsvg
. - I would use
footer
to wrap the entire social-media though :> - Also, you could use
ul
to wrap the social-media-links since those are "list" of links. - Lose the word "link" for each
a
tag , sincea
tag is already a link right.
Aside from those, great job again on this one.
Marked as helpful
@michuux
Posted
@pikamart Hi. Thanks for advice. I hope I managed to fix what you mentioned well