huddle single landing page

Community feedback

• 

  

  Grace•32,130

  @grace-snow

  Posted over 3 years ago

  Hi Maria

  It's a shame you've used bootstrap for this. I can see that's holding back your own css learning here. I recommend for your next challenge you ditch the library and write it all yourself, you'll learn much better that way. You can always pick up libraries and frameworks later on

  Some suggestions for this

  • alt text is really important and needs to be written properly or sometimes left empty on purpose. The most important information on this whole page is the logo - the name of the product - and you've hidden it from search engines and assistive tech users by writing "logo" as the alt
  • look up when a button should be a button element and when it should be an anchor tag
  • this solution is broken for me on mobile because you've disabled scroll with overflow hidden. I can only see part of the solution on mobile
  • in css you are setting a lot of widths and heights. As you write your own css instead of using a library, it will become clearer why that's usually a bad idea. The approach will cause problems
  • if using a 3rd party library you need to stick to their breakpoints, not deviate
  • don't forget to add focus-visible styles to all interactive elements as well as hover styles. Really important for keyboard users.

  I hope this helps for now, good luck

  03

  Marked as helpful