Vanza Setia• 27,855
@vanzasetia
Posted
👋 Hi there!
I have some feedbacks on this soultion:
- There is no
:hovereffect on the Register button element. I think there's anactive-stateimage from the Frontend Mentor, just follow it. Also all the links. - Each social media icon should be wrapped in an anchor tag. Also don't use
itag, since it's not semantic and ambigu. So do this instead. To learn more see this reference.
<span class="social-links fab fa-facebook-f" aria-hidden="true"></span>
- The
bodyelement contain two main font families, I would recommend to only apply one custom font family on thebodyfont family and as far as I remember, the heading tags have different font famliy. If so, then just apply another font family on heading elements.
That's it! Hopefully this is helpful!
0
abhijain2003• 180
@abhijain2003
Posted
@vanzasetia thanks for your feedback . i used font awesome library for social media icons so all icons have default <i> tag.
0
