Ahmed Bayoumi• 6,800
@Bayoumi-dev
Posted
Hey Haruto,
It looks good!... You have some accessibility issues
that need to fix.
Heading levels should only increase by one
, Useh2
instead ofh3
and Useh3
instead ofh4
...Ordered headings
make it easier to navigate and understand when using assistive technologies.Links must have the discernible text,
Set the attributearia-label
to describe the link. Example:
<a href="#facebook" aria-label`="facebook profile">
<i class="fa-brands fa-facebook-f"></i>
</a>
- I suggest you don't use
<button>
with<a>
...
So When to use the button
and when to use the anchor link
???!...
It depends on what you want to happen after clicking... will it redirect the user to another page or section, Use the anchor link
<a> Otherwise, use the button
Buttons
are used for actions like opening or closing something or sending a form.Links
are used for navigation and actions.
I hope this is useful to you... Keep coding👍
Marked as helpful
0
HarutoAmakawa• 220
@HarutoAmakawa
Posted
@Bayoumi-dev Thank you for your advice.
0