Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

huddle-landing-page-with-curved-sections

Karim 810

@Karimsamir112

Desktop design screenshot for the Huddle landing page with curved sections coding challenge

This is a solution for...

  • HTML
  • CSS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Please feel free to give feedbacks !

Community feedback

@Amir-Jacobs

Posted

Hi Karim

I took a quick look and I have some suggestions:

  • I'd stop using <br> to create space between elements. Instead, use margin or padding.
  • Your indentation could be improved -- perhaps look at how a code beautifier would indent your code.
  • In some cases I see inline-styling (such as <h1 style="font-size: 65px">2.7m+</h1>. I would put all styling in your CSS file instead.
  • Your class names and id's could be more descriptive. It's difficult to immediately tell what #final or #final2 is.
  • You also have some html and accessibility issues (there's a report of it on this page).

You're on the right track. 😄

2

Karim 810

@Karimsamir112

Posted

@Amir-Jacobs yes I understood , thanks you so much

0

@ArshKarpoor

Posted

99% Perfect 👌

This is very nice

But I have one 1️⃣ suggestion:-

You can use fonts from styleguid.md

2

Karim 810

@Karimsamir112

Posted

@ArshKarpoor ya okay , thanks you

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord