Hi ASAMU2149
Congratulations for taking this step in your journey to get better at Web development. The HTML looks good , it will needs some few adjustments as follows:
- One of the best practices is to have dedicated files for HTML and then another one for CSS.
- in your HTML, include landmark region elements which provide a poweful way to identify the organization and structure of a web page. These includes the
main, header and footerelements. In this project you may need only themainand maybe the footer element. You can find out more on mdn - main element. Change thesectionelement into themainelement, and you can change the div with the attribution to the footer element. Find out more about semantic elements in general. - the
bodywidth should not be tempered with , it should always be the device width. The only change is applied asmin-height: 100vhto allow a full screen view and scroll vertically if the content exceeds the height above. heightandwidthon elements should be avoided in most cases. The height should be decided by the elements themselves whilst on the width (in this case) you need to usemax-widthso that the width does not exceed a certain value. Here is an artcle to help you on Why font-size must NEVER be in pixels- it is very important to target classes when styling
0
